Repository navigation
test(pic): allow more time for deploying the NNS dapp - #313
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted timeout changes correctly address the documented CI flakiness without altering production behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Raises timeouts for the CI-intensive NNS dapp deployment test without affecting other tests.
Changes:
- Sets the PocketIC processing timeout to 120 seconds.
- Sets this test’s Jest timeout to 180 seconds.
| File | Description |
|---|---|
packages/pic/tests/src/http-gateway.spec.ts |
Adds test-specific timeouts for NNS dapp deployment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lwshang
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpGateway › deploys and serves the NNS dapphit the PocketIC client's 30 s request timeout in two consecutive CI runs (#311, #310), and passed on rerun both times. It deploys the NNS, SNS, II and the NNS dapp. That takes about 11 s locally, but it can go past 30 s on CI, where the test files run in parallel against one PocketIC server.This test now uses
processingTimeoutMs: 120_000and a 180 s Jest timeout, which caps the 60 s default. The other tests keep their defaults. With the timeout forced down to 2 s, the test fails with the sameServerRequestTimeoutErroras on CI.🤖 Generated with Claude Code