This repository was archived by the owner on Aug 24, 2026. It is now read-only.
feat: preconditions for installing code - #5728
Closed
mraszyk wants to merge 3 commits into
Closed
Conversation
github-actions
Bot
added
the
interface-spec
Dfinity-Bjoern
approved these changes
May 13, 2025
Dfinity-Bjoern
left a comment
Dfinity-Bjoern
left a comment
Contributor
There was a problem hiding this comment.
Looks good, please proceed and merge in line with roll-out
Contributor
|
Should we do the same for |
Contributor
Author
Makes sense to me. |
Member
|
@mraszyk can we merge this? |
Contributor
Author
Not really because it is not implemented in the protocol (this PR is merely a suggestion for a new protocol feature). |
mraszyk
marked this pull request as draft
August 13, 2025 11:23
Member
|
This repository has been replaced by dfinity/developer-docs, live at docs.internetcomputer.org, and is being archived, so no further merges will happen here. Closing this PR — if the change is still relevant, please open an equivalent PR against dfinity/developer-docs. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR specifies preconditions for installing canister code via the corresponding management canister endpoints that must be satisfied (if provided) for the call to succeed. The motivation is to prevent canisters that are not stopped from being installed and to enable compare-and-swap semantics for installing canisters (by atomically "comparing" the canister history before "swapping" the canister code).