[FIX] Custom attribute tabs not displayed in the add case modal - #1109
Open
wtg-kierangrech wants to merge 1 commit into
Open
[FIX] Custom attribute tabs not displayed in the add case modal#1109wtg-kierangrech wants to merge 1 commit into
wtg-kierangrech wants to merge 1 commit into
Conversation
b72d079 reordered custom attribute tab-pane ids to put the attribute name first (itab_<name>_<index>) so they are valid CSS selectors for the updated Bootstrap, but the hand-built nav in modal_add_case.html kept the old order (itab_<index>_<name>). The nav hrefs therefore match no tab-pane id and the attribute tabs in the add case modal cannot be opened. Align the href with the id generated by modal_attributes_tabs.html. Same class of issue as dfir-iris#758 and dfir-iris#798.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #798 — completes b72d079 / 8103c2d, which reordered the custom attribute tab-pane ids but missed the add case modal's hand-built nav.
Summary
Bug Fixes
itab_<name>_<index>) so the tabs open again.Root cause (short)
1_details) — invalid CSS selectors that the old jQuery/Bootstrap (Sizzle) tolerated. The dependency upgrade (d1b5c61 on the 2.4.x release line, earlier on develop) resolves tab targets viadocument.querySelector, which rejects them. b72d079 / 8103c2d fixed the shared templates on develop; this PR fixes the last remaining nav. The 2.4.x line back-ported the upgrade without those two fixes, which is why v2.4.29 regressed while v2.4.27 works.