Add ShadowRoot support.#1169
Draft
dmjio wants to merge 1 commit into
Draft
Conversation
For truly encapsulated styles (breaks the cascade in CSS), this PR introduces `shadowRoot :: Bool`. This will allow users to nest Component without style inheritance - [x] Add `shadowRoot` - [x] Define and call `attachShadow` on `Component` mount element. - [ ] Wire-up to styles - [ ] Wire-up to scripts
dmjio
force-pushed
the
master
branch
3 times, most recently
from
3c337c8 to
863bafa
Compare
dmjio
force-pushed
the
master
branch
3 times, most recently
from
3f8ac8b to
eb9fa23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For truly encapsulated styles (breaks the cascade in CSS), this PR introduces
shadowRoot :: Bool.This will allow users to nest Component without style inheritance
shadowRootattachShadowonComponentmount element.