Repository navigation
test(hooks): skip stdin JSON test when jq is missing - #4800
Open
onatozmenn wants to merge 1 commit into
Open
onatozmenn wants to merge 1 commit into
onatozmenn wants to merge 1 commit into
Conversation
Signed-off-by: onatozmenn <onatozmen44@gmail.com>
aheritier
added
area/testing
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
printStdinJSONFieldCmdshells out tojqon non-Windows platforms. Whenjqis absent, the hook still runs and exits cleanly with no output, so the test fails on its content assertion instead of reporting the missing tool. Both tests that use the helper now skip with a reason namingjq.The Windows helper takes the same
*testing.Tparameter for signature parity; PowerShell'sConvertFrom-Jsonis built in, so that variant never skips.Closes #4052.
Validation:
go test ./pkg/hooks/...GOOS=linux GOARCH=amd64 go test -c ./pkg/hooks(compile check for the POSIX helper)go vet ./pkg/hooks/#4053 proposed the same fix but is stale and has merge conflicts; this is a fresh implementation against current
main.