Repository navigation
Drop the expected failures from the Examples check - #66
Merged
Merged
Conversation
TESTed now puts typed literal arguments of Haskell calls in parentheses (dodona-edu/universal-judge#732), so smallest/haskell, the only expected failure, passes. With the Examples check in place no new expected failures should arrive, so the mechanism goes: a reference solution that isn't judged correct fails the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TomNaessens
force-pushed
the
chore/568-smallest-haskell-passes
branch
from
October 21, 2026 15:46
426261a to
d2246c2
Compare
TomNaessens
changed the title
TomNaessens
marked this pull request as ready for review
October 21, 2026 15:49
TomNaessens
enabled auto-merge
October 21, 2026 15:49
bmesuere
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the expected-failure mechanism from
.github/check-examples.sh: theexpected_failurefunction, its "UNEXPECTED PASS" and "expected failure" outcomes. A reference solution that isn't judged correct now simply fails the check.Its only entry,
smallest/haskell, passes since dodona-edu/universal-judge#732: TESTed used to writesmallest 5 :: Int 6 :: Int, which GHC can't parse (dodona-edu/universal-judge#568), and now writessmallest (5 :: Int) (6 :: Int). With the Examples check in place, no new expected failures should arrive: an example that TESTed can't judge correctly doesn't get merged.Manual testing
Examplescheck on this PR (it runs against TESTed master) passes for every language and printsok smallest (haskell).grep -rn "expected_failure\|UNEXPECTED" .githubfinds nothing.🤖 Generated with Claude Code