Skip to content

Drop the expected failures from the Examples check #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomNaessens merged 1 commit into from
Oct 21, 2026
Merged

Drop the expected failures from the Examples check #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions .github/check-examples.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,6 @@

JUDGE=${JUDGE:-/judge}

# Exercise/language pairs that must fail until fixed; they fail the check once they pass.
# smallest/haskell: TESTed generates `smallest 5 :: Int 6 :: Int`, https://github.com/dodona-edu/universal-judge/issues/568
expected_failure() {
case $1 in
smallest/haskell) return 0 ;;
esac
return 1
}

# Per exercise (a directory under tested/ with a config.json): <exercise>\t<suite>\t<solution or empty>.
LIST='
import json, os, sys
Expand Down Expand Up @@ -150,13 +141,8 @@ while IFS=$tab read -r exercise suite solution; do
passed=false
fi

if $passed && expected_failure "$exercise/$language"; then
echo "UNEXPECTED PASS $exercise ($language): remove \"$exercise/$language\" from expected_failure in .github/check-examples.sh"
exit_code=1
elif $passed; then
if $passed; then
echo "ok $exercise ($language)"
elif expected_failure "$exercise/$language"; then
echo "expected failure $exercise ($language)"
else
echo "FAIL $exercise ($language)"
cat "$details"
Expand Down
Loading