[codex] Expose end-of-month scheduling on IborSwap#240
Open
gyx09212214-prog wants to merge 2 commits into
Open
[codex] Expose end-of-month scheduling on IborSwap#240gyx09212214-prog wants to merge 2 commits into
gyx09212214-prog wants to merge 2 commits into
Conversation
Owner
|
Thanks. I agree this is a useful feature and exposing end_of_month on IborSwap seems consistent with the existing schedule machinery. Before merging, I’d like to check the hidden Unicode warning and possibly add one or two more tests around non-EOM effective dates and floating-leg schedules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
end_of_monthschedule option onIborSwapThis keeps the existing default behavior unchanged while giving users a direct way to request EOM-aligned swap schedules when bootstrapping curves from month-end effective dates.
Closes #222.
Validation
python -m pytest unit_tests\test_FinIborSwap.py -qgit diff --check