Skip to content

Prepare xpj conf for using .nimp.conf instead of baseNimp.conf - #22

Open
jasugun wants to merge 1 commit into
mainfrom
lca/nimp_conf
Open

Prepare xpj conf for using .nimp.conf instead of baseNimp.conf#22
jasugun wants to merge 1 commit into
mainfrom
lca/nimp_conf

Conversation

@jasugun

@jasugun jasugun commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

Rework how we load nimp conf files:

  • Set is_unreal if .nimp conf file is detected in unreal base path
  • Load legacy generic nimp conf first (if no unreal detected, or unreal <= 4.24)
  • Load monorepo conf if monorepo unreal is detected
  • Monorepo conf consists of base xpj .nimp.conf, overridable by specific uproject conf
  • Temporarily maintain deprecated xpj .baseNimp.conf (so we have time to replace them by .nimp.conf files)

@tdesveaux
tdesveaux self-requested a review November 24, 2021 12:05

@samhocevar samhocevar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me.

@tdesveaux
tdesveaux removed their request for review November 25, 2021 09:06
@jasugun
jasugun requested review from ftith and tdesveaux November 8, 2022 10:37
@tdesveaux
tdesveaux deleted the branch main April 4, 2025 09:12
@tdesveaux tdesveaux closed this Apr 4, 2025
@tdesveaux

Copy link
Copy Markdown
Contributor

Wrongly closed by dev branch deletion

@tdesveaux tdesveaux reopened this Apr 4, 2025
@tdesveaux
tdesveaux changed the base branch from dev to main April 4, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants