Add thread-safety documentation to JsonSerializer class page#12715
Draft
Copilot wants to merge 2 commits into
Draft
Add thread-safety documentation to JsonSerializer class page#12715Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Document thread safety of JsonSerializer class
Add thread-safety documentation to JsonSerializer class page
Jun 5, 2026
eiriktsarpalis
approved these changes
Jun 5, 2026
github-actions
Bot
added
the
needs-area-label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JsonSerializerclass page lacks explicit thread-safety documentation. While the conceptual docs mention the serializer was designed with thread safety in mind, this information should be directly on the API reference page per standard .NET documentation practice.<threadsafe>element toJsonSerializer.xmlfollowing the established pattern used byConcurrentDictionary,ConcurrentQueue, etc.JsonSerializerOptionscaveat: instances are not thread-safe during initial mutable configuration, but are safe to share once made read-only (e.g., after being passed to a serializer method)