Skip to content

[bgen] Replace XPath lookups with Dictionary in DocumentationManager #25521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 1 commit into from
May 27, 2026
+15 −5
Merged

[bgen] Replace XPath lookups with Dictionary in DocumentationManager #25521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/bgen/DocumentationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,25 @@

public class DocumentationManager {
string xml;
XmlDocument? doc;
Dictionary<string, XmlNode>? memberLookup;

public DocumentationManager (string assembly)
{
this.xml = Path.ChangeExtension (assembly, ".xml");
if (File.Exists (xml)) {
doc = new XmlDocument ();
var doc = new XmlDocument ();
doc.LoadWithoutNetworkAccess (xml);
// Pre-build a dictionary for O(1) member lookups instead of
// O(n) XPath queries on every TryGetDocumentation call.
var members = doc.SelectNodes ("/doc/members/member[@name]");
if (members is not null) {
memberLookup = new Dictionary<string, XmlNode> (members.Count);
foreach (XmlNode member in members) {
var name = member.Attributes? ["name"]?.Value;
if (name is not null)
memberLookup [name] = member;
}
}
}
}

Expand All @@ -38,14 +49,13 @@ public bool TryGetDocumentation (MemberInfo member, [NotNullWhen (true)] out str
{
documentation = null;

if (doc is null)
if (memberLookup is null)
return false;

if (!TryGetId (member, out var id))
return false;

var node = doc.SelectSingleNode ($"/doc/members/member[@name='{id}']");
if (node is null)
if (!memberLookup.TryGetValue (id, out var node))
return false;

if (transformNode is not null)
Expand Down
Loading