Skip to content

Fixes WinForms PrintPreviewControl ForeColor displays incorrectly only when set to White #14424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardobossan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes WinForms PrintPreviewControl ForeColor displays incorrectly only when set to White #14424

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b3f581
Fixes #14420
Mar 26, 2026
ae86f32
Handles Feedbacks
Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Windows.Forms/System/Windows/Forms/Printing/PrintPreviewControl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ private void CalculatePageInfo()

private void DrawMessage(Graphics g, Rectangle rect, bool isExceptionPrinting)
{
Color brushColor = ShouldSerializeForeColor() ? ForeColor : SystemColors.ControlText;
Color brushColor = ForeColor;
Comment thread
ricardobossan marked this conversation as resolved.
Outdated
if (SystemInformation.HighContrast && Parent is Control parent)
{
brushColor = parent.BackColor;
Expand Down
26 changes: 26 additions & 0 deletions src/test/unit/System.Windows.Forms/System/Windows/Forms/Printing/PrintPreviewControlTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,32 @@ public void ShowPrintPreviewControl_BackColorIsCorrect()
Assert.Equal(Color.Green.ToArgb(), actualBackColorArgb);
}

[Fact]
public void PrintPreviewControl_ForeColor_DefaultIsWhite()
{
PrintPreviewControl control = new();

Assert.Equal(Color.White.ToArgb(), control.ForeColor.ToArgb());
}

[Fact]
public void PrintPreviewControl_ForeColorWhite_ShouldSerializeReturnsFalse()
{
PrintPreviewControl control = new();

// White is the default, so ShouldSerializeForeColor should return false.
Assert.False(control.TestAccessor.Dynamic.ShouldSerializeForeColor());
}

[Fact]
public void PrintPreviewControl_ForeColorNonDefault_ShouldSerializeReturnsTrue()
{
PrintPreviewControl control = new();
Comment thread
ricardobossan marked this conversation as resolved.
Outdated
control.ForeColor = Color.Red;

Assert.True(control.TestAccessor.Dynamic.ShouldSerializeForeColor());
}

[Fact]
public void ShowPrintPreviewControlHighContrast_BackColorIsCorrect()
{
Expand Down
Loading