Fix the focus issue of SmartTag/DropDown by preserving the modal menu tracking of ToolStripDropDown.#14606
Open
LeafShi1 wants to merge 1 commit into
Open
Conversation
… tracking of ToolStripDropDown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14600
Root Cause
PR #14491 tightened ToolStrip focus handling to avoid accidental menu activation for normal tab navigation.
The new logic worked for regular ToolStrip, but it also affected ToolStripDropDown scenarios (including SmartTag-hosted UI):
Proposed changes
WM_SETFOCUS/WM_KILLFOCUSto treat DropDown and non-DropDown separately.Customer Impact
Regression?
Risk
Screenshots
Before
The SmartTag dialog doesn't disappear when switch the Tabpage items
Actual11.mp4
After
The SmartTag can be closed normally when switching the TabPage items
AfterChanges.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow