migrate to ddev#773
Draft
vincent-gao wants to merge 10 commits into
Draft
Conversation
…contrib. - Adopt ddev/ddev-drupal-contrib: module repo is the composer root, `ddev poser` builds a disposable Drupal site into web/, `ddev symlink-project` symlinks the module into web/modules/custom/tide_core (live code edits, no sync step). - Fold composer.dev.json into composer.json (require-dev, autoload-dev, allow-plugins, full installer-paths targeting web/); tide_test now comes from the monorepo, not a separate VCS repo. - Pin dev-site core via DRUPAL_CORE=10.6.x in .ddev/config.yaml. - Add services: Elasticsearch 7.17 add-on, Selenium Chrome add-on, custom ClamAV compose file (tide_core hard-depends on clamav module). - Add `ddev install-site` command (testing profile + tide_core/tide_test, points clamav at the local ddev service). - Point behat.yml/phpunit.xml.dist at web/ docroot and ddev service hostnames; phpunit unit suite now also covers modules/*/tests/src/Unit.
Replaced by DDEV (see previous commit). CircleCI scripts still reference ahoy and need a follow-up rewrite.
SD-1341 (44f83b5) changed makeMenuName() to append term ids and truncate the result to 32 characters, but the test still stubbed only getName(). Stub id() on mocked terms and update the provider to expect id-based, truncated menu names. This was never caught because the legacy CI phpunit suite path (./dpc-sdp/*/tests/src/Unit) did not cover module unit tests.
The tide_build job now provisions the same DDEV environment as local development (start, poser, symlink-project, install-site), lints with phpcs and runs the tide_core unit and Behat suites. Per-module Behat suites and the export_config job are commented out pending follow-up. Also excluded DDEV-generated files from phpcs.
views.view.media_report and views.view.tide_content_report depend on user.role.administrator, which tide_core only provides as optional config. During a site installation with the tide profile, optional config is deferred to the end of the install, so tide_site's install-time config failed validation with an UnmetDependenciesException. As optional config, the views are imported at the end of installation, after the role exists. Updated tide_site_update_10005/10006/10007 to read the view config from config/optional accordingly. Verified with a fresh 'drush si tide' via the tide repo DDEV build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA issue: https://digital-vic.atlassian.net/browse/SUPSSP-
Changed
Screenshots