Split cache cleanup test assertions with weakrefs - #587
Merged
Merged
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
======================================
Coverage 94.4% 94.4%
======================================
Files 28 28
Lines 2290 2290
======================================
Hits 2164 2164
Misses 126 126 🚀 New features to boost your workflow:
|
…jects from filesystem lag Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
pjbull
force-pushed
the
weakref-cache-cleanup
branch
from
September 26, 2026 17:20
e30a32d to
2c5dc91
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__del__could not run) from filesystem lag or a real cleanup bug.test_manual_cache_clearingthat mixedgc.collect()withexists()checks.Test plan
make test— 1111 passed, 18 skippedUSE_LIVE_CLOUD=1 make test-live-cloud— 1116 passed, 13 skippedMade with Cursor