Skip to content

Split cache cleanup test assertions with weakrefs - #587

Merged
pjbull merged 3 commits into
masterfrom
weakref-cache-cleanup
Sep 26, 2026
Merged

pjbull merged 3 commits into
masterfrom
weakref-cache-cleanup

Conversation

@pjbull

@pjbull pjbull commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Cache cleanup tests now prove objects were garbage collected via weak references before polling for file removal.
  • Failures distinguish a still-referenced object (so __del__ could not run) from filesystem lag or a real cleanup bug.
  • Replaces the broad retry in test_manual_cache_clearing that mixed gc.collect() with exists() checks.

Test plan

  • Mocked suite: make test — 1111 passed, 18 skipped
  • Live backends: USE_LIVE_CLOUD=1 make test-live-cloud — 1116 passed, 13 skipped
  • CI green on Linux, macOS, and Windows

Made with Cursor

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request September 25, 2026 23:31 Inactive
@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.4%. Comparing base (9df4281) to head (8ad07b7).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #587   +/-   ##
======================================
  Coverage    94.4%   94.4%           
======================================
  Files          28      28           
  Lines        2290    2290           
======================================
  Hits         2164    2164           
  Misses        126     126           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pjbull and others added 2 commits September 26, 2026 10:20
…jects from filesystem lag

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@pjbull
pjbull force-pushed the weakref-cache-cleanup branch from e30a32d to 2c5dc91 Compare September 26, 2026 17:20
Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions
github-actions Bot temporarily deployed to pull request September 26, 2026 17:23 Inactive
@pjbull
pjbull merged commit 59f61b3 into master Sep 26, 2026
28 checks passed
@pjbull
pjbull deleted the weakref-cache-cleanup branch September 26, 2026 17:50

This branch was previously deployed

1 inactive deployment
pull request — 8ad07b75 Deployed Sep 26, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant