Repository navigation
ENDOOM Cleanup Fixes - #1017
Merged
Merged
ENDOOM Cleanup Fixes#1017
Conversation
- Fixes some resource cleanup issues
- Also close window immediately when doing endoom_export
Pedro-Beirao
approved these changes
Oct 1, 2026
Pedro-Beirao
left a comment
Pedro-Beirao
left a comment
Member
There was a problem hiding this comment.
Everything looks fine thanks!
Just didnt test the controller buttons, but looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding some Nyan fixes...
More importantly this closes the game window immediately when
endoom_exportis on. There was an issue before where the game window would stay open (this is because we want this for the windowed endoom, just not for the terminal endoom).