Skip to content

feat: implement getIssueStore/getMetadata in NullXtextTargetPlatform #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenporras merged 1 commit into from
Sep 8, 2026
Merged

feat: implement getIssueStore/getMetadata in NullXtextTargetPlatform #1529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/layered/IXtextTargetPlatform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ public interface IXtextTargetPlatform {
* Besides resource descriptions a platform may contain issues. For symmetry reasons,
* these are managed through an {@link IIssueStore}, just as resource descriptions are
* managed through an {@link IResourceDescriptionsData}.
* If a platform does not manage issues, it shall return {@code null}.
*
* @return the platform's issue store, or {@code null} if none.
*/
Expand Down
23 changes: 21 additions & 2 deletions ...valoq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/layered/NullXtextTargetPlatform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,19 @@
package com.avaloq.tools.ddk.xtext.layered;

import java.util.Collection;
import java.util.List;
import java.util.Map;

import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.emf.common.util.URI;
import org.eclipse.xtext.validation.Issue;

import com.avaloq.tools.ddk.xtext.build.IBinaryModelStore;
import com.avaloq.tools.ddk.xtext.resource.IDerivedObjectAssociationsStore;
import com.avaloq.tools.ddk.xtext.resource.extensions.IResourceDescriptionsData;
import com.avaloq.tools.ddk.xtext.resource.extensions.NullResourceDescriptionsData;
import com.google.common.collect.ImmutableMultimap;
import com.google.common.collect.Multimap;


/**
Expand All @@ -43,7 +48,21 @@ public void close(final IProgressMonitor monitor) {

@Override
public IIssueStore getIssueStore() {
return null;
return new IIssueStore() {
@Override
public Multimap<URI, Issue> getIssues() {
return ImmutableMultimap.of();
}

@Override
public Iterable<Issue> getIssues(final URI uri) {
return List.of();
}

@Override
public void storeIssues(final URI forUri, final Iterable<Issue> issues) {
}
};
}

@Override
Expand All @@ -58,7 +77,7 @@ public IBinaryModelStore getBinaryModelStore() {

@Override
public Map<String, String> getMetadata(final Collection<String> keys, final IProgressMonitor monitor) {
return null; // NOPMD ReturnEmptyCollectionRatherThanNull
return Map.of();
}

@Override
Expand Down