Repository navigation
perf(tests): run-all --changed picks suites by the diff, parallel by default on macOS - #664
Merged
Merged
Conversation
The full glob is 13-15 minutes sequential on a Mac and every in-session worker was paying for it as its pre-push check. --changed selects suites by basename match, changed suites themselves, tests/test-<mod>*.sh for lib/<mod>/, plus test-meta for anything outside lib/. CI keeps the full glob. RUN_ALL_JOBS defaults to auto on macOS: every parallel run there, CI and local, has been green; the flake that reverted the default in #647 is ubuntu-only, so Linux stays at 1.
A header comment naming a file is documentation, not a dependency: the wavefront suite's comment mentions run-all.sh and cost a 300s timeout on the first dogfood run. Selection now reads code lines only. Six suites carry an '# always:' header and run on every --changed diff: kit-contract, config-registry, no-personal-paths, no-scattered-ids, boundary-lint, meta. They fail on a file you add while naming no file you touched, so no diff-derived pick can reach them. Measured floor on the Air: 72s serial for the five small ones, test-meta about 140s.
tieubao
force-pushed
the
perf/run-all-changed
branch
from
September 16, 2026 15:21
150550f to
5b504fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/run-all.sh --changed [<base>]runs only the suites the diff against<base>touches (default base: the merge-base withorigin/master). Picks: suites whose code lines name a changed file's basename, changed suites themselves,tests/test-<mod>*.shforlib/<mod>/, plus every suite with an# always:header.# always:and run on every diff: kit-contract, config-registry, no-personal-paths, no-scattered-ids, boundary-lint, meta. They fail on a file you add while naming no file you touched, so a diff-derived pick can never reach them.RUN_ALL_JOBSdefaults toautoon macOS, where every parallel run has been green. Linux stays at1until the ubuntu flake from fix(ci): default the runner back to sequential, parallel is opt-in #647 is understood.Why
The full glob is 13-15 minutes sequential on a Mac and every in-session worker paid it as the pre-push check. On this branch
--changedpicked 11 suites and finished in 124s, all green. CI keeps the full glob.Proof
docs/verification/run-all-changed.md: green run of the real flow, the negative control (master runner, 6 of 7 cases red, restored), the first dogfood run that drove the code-lines-only match, and what is not proven.