Skip to content

fix(build): move WASM packager out of .github - #324

Merged
jaromil merged 1 commit into
dyne:masterfrom
marillat:patch-1
Nov 6, 2026
Merged

jaromil merged 1 commit into
dyne:masterfrom
marillat:patch-1

Conversation

@marillat

@marillat marillat commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

The native packaging contract reuses the WASM release packager. Keeping that helper under .github/ makes the test depend on GitHub-specific files that source packages may omit. Removing its argument breaks the test's required three-argument interface.

Move package-wasm-release.sh to cmake/ with the build tooling, update its source-root lookup, and point CTest and both WASM release jobs to the new location.

Validation: the wasm-release-package CTest passes in the checkout and in an exported source tree without .github/ or .git/, including source/build paths containing spaces. Both WASI and Emscripten package fixtures are verified. Bash syntax, ShellCheck, and release-workflow YAML/reference checks pass.

Fixes #323.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

✅ Conventional Commits check passed

All commit messages in this PR now follow the Conventional Commits specification. 🎉

@marillat marillat changed the title Don't load file from .github directory Fix issue #323 Nov 6, 2026
@marillat marillat changed the title Fix issue #323 Fix: issue #323 Nov 6, 2026
Keep the shared packaging helper with the CMake build tooling so source exports can omit GitHub-specific files. Update the packaging test, both WASM release jobs, and the helper source-root lookup.
@jaromil jaromil changed the title Fix: issue #323 fix(build): move WASM packager out of .github Nov 6, 2026
@jaromil
jaromil merged commit 868a761 into dyne:master Nov 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests targert, try to load a file from the hidden directory .git

2 participants