Repository navigation
fix(build): move WASM packager out of .github - #324
Merged
Merged
Conversation
✅ Conventional Commits check passedAll commit messages in this PR now follow the Conventional Commits specification. 🎉 |
Keep the shared packaging helper with the CMake build tooling so source exports can omit GitHub-specific files. Update the packaging test, both WASM release jobs, and the helper source-root lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native packaging contract reuses the WASM release packager. Keeping that helper under
.github/makes the test depend on GitHub-specific files that source packages may omit. Removing its argument breaks the test's required three-argument interface.Move
package-wasm-release.shtocmake/with the build tooling, update its source-root lookup, and point CTest and both WASM release jobs to the new location.Validation: the
wasm-release-packageCTest passes in the checkout and in an exported source tree without.github/or.git/, including source/build paths containing spaces. Both WASI and Emscripten package fixtures are verified. Bash syntax, ShellCheck, and release-workflow YAML/reference checks pass.Fixes #323.