Repository navigation
fix(ci): handle Ubuntu runner changes and private SSE helpers - #333
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ubuntu runner change exposes three existing CI problems in the PR #332 run. These are independent of that PR's interpolation changes; this fix starts from
masterat6156f2e.readelf's ELF class and machine fields. The previous grep expectsIntel 80386, while the newfiledescription usesIntel i386, so valid 32-bit builds fail before their tests run.colorenhance'scbrt_sseandpow3_sseheader helpers internal linkage. SSE4.1 builds otherwise expose both as strong external symbols, violating the existing bundle symbol audit.Validation:
masterby building the core bundle with GCC 14 and-msse4.1for C and C++. After the linkage fix, all six native bundle contracts and thecolorenhancetest pass (7/7).git diff --checkpass.After this PR is merged, update PR #332 with the new base so its checks can run with these fixes.