Skip to content

fix(ci): handle Ubuntu runner changes and private SSE helpers - #333

Merged
jaromil merged 1 commit into
masterfrom
fix/ci-contract-checks
Nov 16, 2026
Merged

jaromil merged 1 commit into
masterfrom
fix/ci-contract-checks

Conversation

@jaromil

@jaromil jaromil commented Nov 16, 2026

Copy link
Copy Markdown
Member

The Ubuntu runner change exposes three existing CI problems in the PR #332 run. These are independent of that PR's interpolation changes; this fix starts from master at 6156f2e.

  • Keep the Clang 14 job on Ubuntu 24.04, where its compiler package is available. The failed Ubuntu 26.04 job stops at APT installation before compiling anything.
  • Verify i386 binaries with readelf's ELF class and machine fields. The previous grep expects Intel 80386, while the new file description uses Intel i386, so valid 32-bit builds fail before their tests run.
  • Give colorenhance's cbrt_sse and pow3_sse header helpers internal linkage. SSE4.1 builds otherwise expose both as strong external symbols, violating the existing bundle symbol audit.

Validation:

  • Reproduced the exact two-symbol audit failure on unchanged master by building the core bundle with GCC 14 and -msse4.1 for C and C++. After the linkage fix, all six native bundle contracts and the colorenhance test pass (7/7).
  • The actual i386 verification step accepts six genuine ELF32/i386 fixtures and rejects ELF64, ELF32 with a different machine, and missing binaries. Full multilib execution is left to CI because this host lacks the 32-bit C runtime.
  • Workflow YAML parsing, Bash syntax, ShellCheck on the changed shell step, and git diff --check pass.

After this PR is merged, update PR #332 with the new base so its checks can run with these fixes.

@jaromil
jaromil merged commit 00178b9 into master Nov 16, 2026
12 checks passed
@jaromil
jaromil deleted the fix/ci-contract-checks branch November 16, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant