You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 9, 2024. It is now read-only.
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:
Current behavior
currently the actions use actions/github-script in order to run the main methods.
when using actions/github-script you can't use require directly and need to use __original_require__ that is accessible from this action. This has forced us to override a lot of NX internals in order to bypass the usage of require
Expected behavior
It would be cleaner and more maintainable to remove action/github-script entirely and use the methods with pure js.
We should keep the separation that was made between using github's toolkit and the actions BL, it will make it easier to consider migrating into an docker-based action so it could be possible to use it in gitlab as well
I'm submitting a...
Current behavior
currently the actions use
actions/github-scriptin order to run the main methods.when using
actions/github-scriptyou can't userequiredirectly and need to use__original_require__that is accessible from this action. This has forced us to override a lot of NX internals in order to bypass the usage ofrequireExpected behavior
It would be cleaner and more maintainable to remove
action/github-scriptentirely and use the methods with pure js.We should keep the separation that was made between using github's toolkit and the actions BL, it will make it easier to consider migrating into an docker-based action so it could be possible to use it in gitlab as well