[18273] Refactor enum EntityKind::DOMAIN with EntityKind::DOMAIN_ENTITY#195
Open
[18273] Refactor enum EntityKind::DOMAIN with EntityKind::DOMAIN_ENTITY#195
Conversation
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 58.46% 58.46%
=======================================
Files 38 38
Lines 4485 4485
Branches 2383 2383
=======================================
Hits 2622 2622
Misses 55 55
Partials 1808 1808
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Also checked on macOS Ventura 13.4, Xcode 14.3.1. Issue is legacy BSD extensions to the C standard defined in If Fast-DDS-monitor is similarly patched the monitor builds and runs on macOS (good to have!). Could this change please be merged, it's a pre-requisite for: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid a compilation issue with
clang#184 a refactor of EntityKind::DOMAIN with EntityKind::DOMAIN_ENTITY.This implies an API Break.