Small refactorings#6476
Open
line-o wants to merge 8 commits into
Open
Conversation
Without this change the test suite reproducibly failed with cannot bind to 0.0.0.0:8088
Return early and use new switch-statement in order to simplify the flow within FunctionFactory.createFunction
Introduce new private method functionNotFoundErrorDescription in order to make resolveForwardRefences easier to understand.
* Return early in order to reduce indentation. * Fix comments * Fix formatting
Two separate instances of the same code that ran after FunctionFactory.createFunction indicated that it might be better to have both pieces run the same code to counter drift. The new method FunctionFactory.createFunctionCall ensures that the RHS of ArrowOperator is treated as other functionCalls in XQuery.
The four string operation optimization functions startsWith, endsWith, contains and equals where doing almost the same thing. They are now generalized into optimizeStringFunction.
duncdrum
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One test kept failing on my local machine with a fixed port (could not bind to 8088)
I switched it to using a random port instead. Please review this with care as well.
Add a new helper function to FunctionFactory to keep logic from to two call sites in one place:
Reformat and refactor for readability and maintainability
Smaller refactorings for readability and maintainability in