Repository navigation
fix(kafka): retry mqtt producer startup - #1526
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the KafkaMQTT filter to avoid failing pipeline initialization when Kafka is unavailable at startup by retrying sarama async producer creation in the background, while exposing a new producerUnavailable result and documenting the behavior.
Changes:
- Make
KafkaMQTTproducer creation non-fatal on init failure, with exponential-backoff retry until ready. - Add runtime status reporting (
Health/Ready) and a new filter resultproducerUnavailablereturned while the producer is not available. - Update tests to cover retry-on-startup and close-before-reconnect behavior, and document the retry behavior in the MQTT proxy cookbook.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/filters/kafka/spec.go | Makes the mqtt/KV map optional in the filter spec. |
| pkg/filters/kafka/kafka.go | Implements producer retry logic, producer-unavailable result, and status reporting. |
| pkg/filters/kafka/kafka_test.go | Adds tests for startup retry, close behavior, and optional mqtt map spec validation. |
| docs/07.Reference/7.02.Filters.md | Minor doc example/formatting adjustments (unrelated to KafkaMQTT behavior). |
| docs/03.Advanced-Cookbook/3.01.MQTT-Proxy.md | Documents KafkaMQTT startup retry and producerUnavailable behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+269
to
+274
| if k.producer != nil { | ||
| return &Status{ | ||
| Health: "ready", | ||
| Ready: true, | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1525