Save tutorial projects consistently and verify their fit results#191
Open
AndrewSazonov wants to merge 36 commits into
Open
Save tutorial projects consistently and verify their fit results#191AndrewSazonov wants to merge 36 commits into
AndrewSazonov wants to merge 36 commits into
Conversation
AndrewSazonov
added
the
[scope] maintenance
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #191 +/- ##
===========================================
- Coverage 86.08% 80.18% -5.91%
===========================================
Files 262 262
Lines 22044 21984 -60
Branches 2570 2558 -12
===========================================
- Hits 18977 17628 -1349
- Misses 2104 3383 +1279
- Partials 963 973 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every tutorial now saves its project to a predictable
projects/ed_<N>_<name>directory, so running the tutorials — as scripts or as notebooks — leaves a complete, consistently named set of results on disk.A new check parses each saved
analysis.cifand compares the goodness-of-fit (reduced χ² and R-factors) and a few key refined parameters against committed reference values, so an accidental change in a tutorial or in the underlying calculations is caught automatically. The Bayesian (MCMC) tutorials are now seeded so their results are reproducible, and the tutorial CI runs these checks after both the script and notebook runs.