-
Notifications
You must be signed in to change notification settings - Fork 75
feat(a11y): label post action-row + overflow-menu controls for screen readers #3288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /root/ecency-mobile/node_modules | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,8 @@ const IconButton = ({ | |
| size, | ||
| style, | ||
| isLoading, | ||
| accessibilityLabel, | ||
| accessibilityHint, | ||
| }) => ( | ||
| <Fragment> | ||
| <TouchableOpacity | ||
|
|
@@ -33,6 +35,10 @@ const IconButton = ({ | |
| underlayColor={backgroundColor || 'white'} | ||
| disabled={disabled} | ||
| onLongPress={() => !isLoading && onLongPress && onLongPress()} | ||
| accessibilityRole={onPress ? 'button' : undefined} | ||
| accessibilityLabel={accessibilityLabel} | ||
| accessibilityHint={accessibilityHint} | ||
| accessibilityState={{ disabled: !!disabled }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For callers that pass Useful? React with 👍 / 👎. |
||
| > | ||
| {!isLoading ? ( | ||
| <Icon | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit tracks
node_modulesas a symlink to/root/ecency-mobile/node_modules. In any fresh checkout that is not running with that exact machine-local path, the dependency directory is dangling or points outside the repo, so install/test scripts that dereferencenode_modules/...can fail or write under/rootinstead of the workspace. Sincenode_modules/is already ignored, this should stay untracked.Useful? React with 👍 / 👎.