Skip to content

Update XBase to 2023-06 version#2766

Merged
rgrunber merged 1 commit into
eclipse-jdtls:masterfrom
akurtakov:master
Jul 19, 2023
Merged

Update XBase to 2023-06 version#2766
rgrunber merged 1 commit into
eclipse-jdtls:masterfrom
akurtakov:master

Conversation

@akurtakov
Copy link
Copy Markdown
Contributor

No description provided.

@rgrunber rgrunber merged commit 9c2a29d into eclipse-jdtls:master Jul 19, 2023
@rgrunber rgrunber added this to the End July 2023 milestone Jul 19, 2023
@rgrunber rgrunber added the dependencies Pull requests that update a dependency file label Jul 19, 2023
@rgrunber
Copy link
Copy Markdown
Contributor

rgrunber commented Jul 19, 2023

Tested out by confirming type hierarchy still works, and it does. I guess this is fine for now.

@akurtakov Is there anything stopping us from reducing existing usage in our codebase much like eclipse-lsp4j/lsp4j#494 . Not sure if we can outright remove it if other deps from platform are depending on it.

@akurtakov
Copy link
Copy Markdown
Contributor Author

Nothin in platform requires it. And as lsp4j is getting rid of it that should be doable task.

@akurtakov
Copy link
Copy Markdown
Contributor Author

@rgrunber THinking more about it - it's not worth the effort. When #2033 lands this code will be gone so not worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants