Skip to content

skip restoring terminals with missing working directory - #2878

Open
danthe1st wants to merge 2 commits into
eclipse-platform:masterfrom
danthe1st:restore-terminal-skip-nonexisting
Open

skip restoring terminals with missing working directory#2878
danthe1st wants to merge 2 commits into
eclipse-platform:masterfrom
danthe1st:restore-terminal-skip-nonexisting

Conversation

@danthe1st

@danthe1st danthe1st commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Since we already have M3 now, this may be better for Eclipse 2026-12 but that's a decision for committers.


With restoring terminals now properly restoring the working directory, it doesn't really make sense to restore terminals pointing to a directory that no longer exists so this PR skips restoring these terminals (see also #2859).

I also used this chance to extract the logic for restoring a single terminal from the stored connection properties into a method for better readability.

@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   59m 24s ⏱️ + 6m 37s
 4 761 tests ±0   4 739 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 174 runs  ±0  12 021 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit b0d0ca8. ± Comparison against base commit 32495fb.

♻️ This comment has been updated with latest results.

@danthe1st
danthe1st force-pushed the restore-terminal-skip-nonexisting branch from 8f2498c to 103db30 Compare August 30, 2026 13:56
@eclipse-platform-bot

Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

terminal/bundles/org.eclipse.terminal.view.ui/META-INF/MANIFEST.MF
terminal/features/org.eclipse.terminal.feature/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From a68a23466d9ab81c9f84988d54cb8be018ba6f5d Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sun, 30 Aug 2026 14:02:35 +0000
Subject: [PATCH] Version bump(s) for 4.42 stream


diff --git a/terminal/bundles/org.eclipse.terminal.view.ui/META-INF/MANIFEST.MF b/terminal/bundles/org.eclipse.terminal.view.ui/META-INF/MANIFEST.MF
index 9652e27d4a..26ecaadcb4 100644
--- a/terminal/bundles/org.eclipse.terminal.view.ui/META-INF/MANIFEST.MF
+++ b/terminal/bundles/org.eclipse.terminal.view.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.terminal.view.ui;singleton:=true
-Bundle-Version: 1.1.200.qualifier
+Bundle-Version: 1.1.300.qualifier
 Bundle-Activator: org.eclipse.terminal.view.ui.internal.UIPlugin
 Bundle-Vendor: %providerName
 Require-Bundle: org.eclipse.core.expressions;bundle-version="[3.9.0,4.0.0)",
diff --git a/terminal/features/org.eclipse.terminal.feature/feature.xml b/terminal/features/org.eclipse.terminal.feature/feature.xml
index 044c0b1ba2..276e237b4b 100644
--- a/terminal/features/org.eclipse.terminal.feature/feature.xml
+++ b/terminal/features/org.eclipse.terminal.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.terminal.feature"
       label="%featureName"
-      version="1.0.400.qualifier"
+      version="1.0.500.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.55.0

Further information are available in Common Build Issues - Missing version increments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants