[GEF] Deprecate CreateRequest for removal - #1604
Open
ptziegler wants to merge 1 commit into
Open
Conversation
The main difference between the official class and our fork is that we distinguish between the created object and the selected object. However, this is only ever used in the `FieldEditorDropRequest`, where both object happen to be the same. Meaning there is no functional difference that we depend on. Note that the constructor for the GEF request is slightly different. It doesn't expect the factory as argument, but the request type.
ptziegler
force-pushed
the
gef-create-request
branch
from
September 6, 2026 14:59
6265b30 to
7c10b90
Compare
Test Results 4 files ±0 4 suites ±0 2h 13m 11s ⏱️ + 1m 26s For more details on these failures and errors, see this check. Results for commit 7c10b90. ± Comparison against base commit 77eba85. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main difference between the official class and our fork is that we distinguish between the created object and the selected object. However, this is only ever used in the
FieldEditorDropRequest, where both object happen to be the same. Meaning there is no functional difference that we depend on.Note that the constructor for the GEF request is slightly different. It doesn't expect the factory as argument, but the request type.