Skip to content

Increase test coverage#500

Open
sawom666 wants to merge 7 commits into
ecmwf:developfrom
sawom666:develop
Open

Increase test coverage#500
sawom666 wants to merge 7 commits into
ecmwf:developfrom
sawom666:develop

Conversation

@sawom666

Copy link
Copy Markdown
Contributor

Description

Add a test to ensure the function "build" in src/eccodes/CodesFactory.h is fully covered.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@sawom666

Copy link
Copy Markdown
Contributor Author

I also noticed the following file is not used:
eccodes/src/eccodes/AccessorFactory.h
and can be removed

@joobog joobog added the approved-for-ci Approved to run CI on ECMWF machines label Jun 20, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.22%. Comparing base (4a61c80) to head (96f42ed).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #500      +/-   ##
===========================================
+ Coverage    88.16%   88.22%   +0.06%     
===========================================
  Files          854      854              
  Lines        63582    63582              
  Branches     11301    11301              
===========================================
+ Hits         56056    56096      +40     
+ Misses        7526     7486      -40     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sawom666

Copy link
Copy Markdown
Contributor Author

Here are the improvements:
Change in coverage:
third_party/expected/include/tl/expected.hpp 2.22%
src/eccodes/CodesFactory.h 47.22%
src/eccodes/grib_handle.cc 0.37%
src/eccodes/string_util.cc 10.42%
src/eccodes/ExceptionHandler.h 9.09%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-for-ci Approved to run CI on ECMWF machines contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants