Skip to content

Drop the task tool's all-done reminder and trim request checks - #692

Merged
zikajk merged 1 commit into
masterfrom
rework-requirement-checks
Nov 7, 2026
Merged

zikajk merged 1 commit into
masterfrom
rework-requirement-checks

Conversation

@zikajk

@zikajk zikajk commented Nov 7, 2026

Copy link
Copy Markdown
Member

ea46581 and 9d98b88 made the code agent check more than it needs to: the task tool's all-done reminder asks for a second check of the whole request without knowing what was already verified, so after compaction the model redoes everything, and the prompt asks for the most literal reading of loose instructions and for handling edge cases nobody asked for. This removes the reminder (tasks are already verified on complete) and keeps the useful core of the prompt: implement exact stated behavior as stated, don't trust existing tests alone, don't bend tests, handle realistic edge cases rather than hypothetical ones, and say what was verified. Stated requirements now go into each task's acceptance criteria, so each one is checked

  • I added a entry in changelog under unreleased section.
  • This is not an AI slop. (Please take a human time to write a comprehensive context about the problem, alternatives and rationale)

The task tool already makes the model put acceptance criteria in each
task and verify them before `complete`, and task state survives
compaction. The reminder added in ea46581, appended when the last task
is completed, asked for a second sweep over the whole request without
knowing what was already verified, so after compaction the model redid
all of it. Remove it; `all-tasks-done?` stays for
`auto-clear-completed!`.

The code agent's "Meeting the request" section also asked for the most
literal reading of ambiguous requirements, a final requirement by
requirement sweep and checks of failure paths in general, so models
read loose instructions literally and handled edge cases nobody asked
for. Keep its core: implement exact stated behavior as stated, check
stated requirements as existing tests only show old behavior still
works, and say what was verified. Beyond stated behavior, ask for the
edge cases the code will realistically meet, not hypothetical ones:
this guards against doing too much and too little without limiting
open-ended requests, and without asking the model to judge how likely
a case is to be tested. Also tell it not to bend tests. The cleanup
sentence reworded in 9d98b88 goes too, as it was only needed for the
instruction to write check scripts. Stated requirements now go into
the acceptance criteria of the task that implements them, so they are
checked once, on `complete`.

The shell_command note that background jobs stop with ECA stays.
@zikajk
zikajk merged commit 0494653 into master Nov 7, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant