Repository navigation
Collect garbage before each soak memory sample - #46
Merged
Merged
Conversation
The soak run's leak budget compared memory samples taken without a collection, so the reading depended on when the collector last ran. On Linux the same run measured 53 to 153 MiB of growth, and CI failed at 153 (budget 128) with a stable plateau, not a leak. Force a full collection before each metrics sample. Retained memory, the only thing a leak produces, is unaffected; measured growth on Linux is now 12 to 26 MiB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Quality (runtime-d)failed on #44 with "Agent memory footprint grew by more than 128 MiB after warmup" (153 MiB), unrelated to that PR. The samples showed a plateau (110 → 193 → 193 MiB), not a leak. The leak budget measured memory without collecting garbage, so the reading depended on GC timing.Reproduced on Linux (
oven/bun:1.4.2in Docker), with the same run three times: growth 87, 53, 110 MiB.Fix
scripts/resilienceAgent.ts(test harness only) forcesBun.gc(true)before each metrics sample, so the budget measures retained memory. A real leak is retained memory and is still caught; the noise floor drops.Linux, four runs after the change: growth 26, 12, 18, 25 MiB. macOS stays at 0. The 128 MiB budget is unchanged.
🤖 Generated with Claude Code
Summary by CodeRabbit