fix: enforce deploy_results success

[wdconinc]

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

This PR enforces successful deploy_results, now that tokens are refreshed.

What is the urgency of this PR?

• High (please describe reason below)
• Medium
• Low

What kind of change does this PR introduce?

• Bug fix (issue: reasons for allow_failure addressed)
• New feature (issue #__)
• Optimization (issue #__)
• Updated documentation
• other: __

Please check if any of the following apply

• This PR introduces breaking changes. Please describe changes users need to make below.
• This PR changes default behavior. Please describe changes below.
• AI was used in preparing this PR. Please describe usage below.

[Copilot]

Pull request overview

Removes allow_failure: true from the deploy_results CI job so that failures now block the pipeline, since the underlying token refresh issue that justified the allowance has been resolved.

Changes:

• Drop allow_failure: true from the deploy_results job in .gitlab-ci.yml.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[veprbl]

This is not necessarily a good idea. While the tokens may be up to date, the service itself is not at 100% uptime.

[wdconinc]

This is not necessarily a good idea. While the tokens may be up to date, the service itself is not at 100% uptime.

Doesn't that apply to anything then? GitHub? EICweb? apk installs? docker hub container pulls?

But more fundamentally, if we want to publish to pelican for further use or archival, then we should fail the job until it can be retried. This would also clearly flag that the service is down so it can be reported and rectified (and the service made more robust by our frequent nagging).