Skip to content

Revert "zdc_pi0: allow_fail" #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
veprbl wants to merge 4 commits into
base: master
Choose a base branch
from
+0 −2
Open

Revert "zdc_pi0: allow_fail" #306

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b01f3f0
Revert "zdc_pi0: allow_fail (#276)"
veprbl Apr 29, 2026
3c91ee1
Merge branch 'master' into revert-276-pr/zdc_pi0_allow_fail
veprbl May 20, 2026
e8f2404
Merge branch 'master' into revert-276-pr/zdc_pi0_allow_fail
veprbl May 26, 2026
25de07c
Merge branch 'master' into revert-276-pr/zdc_pi0_allow_fail
veprbl May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions benchmarks/zdc_pi0/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,13 @@ sim:zdc_pi0:
bench:zdc_pi0:
extends: .det_benchmark
stage: benchmarks
allow_failure: true # allow to fail until EICrecon 1.37 and epic 26.05
needs: ["sim:zdc_pi0"]
script:
- snakemake $SNAKEMAKE_FLAGS --cores 1 results/epic_zdc_sipm_on_tile_only/zdc_pi0

collect_results:zdc_pi0:
extends: .det_benchmark
stage: collect
allow_failure: true # allow to fail until EICrecon 1.37 and epic 26.05
needs: ["bench:zdc_pi0"]
when: always
script:
Expand Down