Conversation
w0rk3r
requested review from
Aegrah,
Mikaayenson,
Samirbous,
bryans3c and
terrancedejesus
August 24, 2026 18:11
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tunes several Windows-focused detection rules by deprecating a noisy higher-order discovery signal rule, improving PowerShell remote-download coverage, and reducing false positives in the unusual parent/child relationship rule.
Changes:
- Deprecates
Unusual Discovery Signal Alert with Unusual Process Command Lineby settingmaturity = "deprecated"and adding deprecation metadata. - Expands the PowerShell remote file download sequence to include additional PowerShell hosts (
pwsh.exe,powershell_ise.exe) and updates wording in the rule description. - Updates the unusual parent/child relationship rule’s allow/deny conditions and adds a self-spawn exclusion to reduce noise.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rules/windows/privilege_escalation_unusual_parentchild_relationship.toml | Updates parent/child allowlists and adds a self-spawn exclusion to reduce false positives. |
| rules/windows/command_and_control_remote_file_copy_powershell.toml | Broadens PowerShell process coverage for the file-creation stage (and aligns the network stage) and tweaks description text. |
| rules/_deprecated/discovery_signal_unusual_discovery_signal_proc_cmdline.toml | Marks the rule as deprecated and adds deprecation metadata (deprecation_date, deprecated_reason). |
Suppressed comments (1)
rules/_deprecated/discovery_signal_unusual_discovery_signal_proc_cmdline.toml:6
- This rule is being flipped to
maturity = "deprecated", butrule.nameis still not prefixed withDeprecated -(and the investigation guide header also uses the non-deprecated name). Deprecation guidelines expect the name to already be marked as deprecated by the time maturity is set todeprecated, so please prepend the prefix for consistency and clarity in UI/search.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bryans3c
approved these changes
Aug 25, 2026
| dns.question.name regex """.*\.[a-zA-Z]{2,5}"""] | ||
| [file where host.os.type == "windows" and event.type == "creation" and | ||
| process.name : "powershell.exe" and | ||
| process.name : ("powershell.exe", "pwsh.exe", "powershell_ise.exe") and |
Contributor
There was a problem hiding this comment.
Suggested change
| process.name : ("powershell.exe", "pwsh.exe", "powershell_ise.exe") and | |
| process.name : ("powershell.exe", "pwsh.exe", "powershell_ise.exe", "pwsh-preview.exe") and |
https://powershellisfun.com/2026/05/01/powershell-preview-v7-7-0-preview-1-release/
terrancedejesus
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Resolves https://github.com/elastic/ia-trade-team/issues/991
Summary
Unusual Discovery Signal Alert with Unusual Process Command LineRemote File Download via PowerShell2nd process conditionUnusual Parent-Child Relationship