codex-preview: Remove always-true step condition - #221
Open
reakaleek wants to merge 1 commit into
Open
Conversation
The deploy job's if already restricts the run to pull_request and pull_request_target events, so the step-level event check on Create Deployment was always true (and its workflow_dispatch arm unreachable). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Mpdreamz
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Delete the step-level event check on the
Create Deploymentstep incodex-preview.yml.Why
Repo-wide over-engineering audit. The
deployjob'sifalready restricts the run topull_request/pull_request_target, so the step condition was always true — and itsworkflow_dispatcharm was unreachable.How
Removed the redundant
ifline.Test plan
actionlint passes (pre-commit). Behavior is unchanged: the step runs exactly when the job runs.
🤖 Generated with Claude Code