Skip to content

kolide: fix system-test mock pagination origins with stream .request.host - #20521

Open
andrewkroh wants to merge 1 commit into
elastic:mainfrom
andrewkroh:fix/stream-request-host-kolide
Open

kolide: fix system-test mock pagination origins with stream .request.host#20521
andrewkroh wants to merge 1 commit into
elastic:mainfrom
andrewkroh:fix/stream-request-host-kolide

Conversation

@andrewkroh

@andrewkroh andrewkroh commented Aug 4, 2026

Copy link
Copy Markdown
Member

Proposed commit message

Replace stream {{ hostname }}:PORT absolute URLs in Kolide system-test mocks with {{ .request.host }}, bump mock images to stream:v0.23.0, and remove unused PORT compose env vars (listen address is set via --addr).

httpjson/CEL reject pagination when the mock emits a container-ID origin instead of the svc-* alias the agent uses. elastic/stream#206 and elastic/stream#207 expose the inbound request Host so mocks stay same-origin.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Confirm docker.elastic.co/observability/stream:v0.23.0 is published before merge
  • Run Kolide system tests that exercise cursor/next pagination mocks

How to test this PR locally

elastic-package stack up -d --version 9.5.0-SNAPSHOT
cd packages/kolide
elastic-package test system

Related issues

Screenshots

N/A — system-test mock and compose changes only.

@andrewkroh
andrewkroh requested a review from a team as a code owner August 4, 2026 15:22
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@andrewkroh
andrewkroh marked this pull request as draft August 4, 2026 15:25
@andrewkroh andrewkroh added Integration:kolide Kolide Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Aug 4, 2026
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@andrewkroh
andrewkroh force-pushed the fix/stream-request-host-kolide branch from de9f4eb to ed139ea Compare August 4, 2026 15:31
…host

Replace {{ hostname }}:PORT absolute URLs with {{ .request.host }} and bump
mock images to stream v0.23.0 so pagination stays same-origin. Drop unused
PORT compose env vars (listen address is set via --addr).

Test-only changes; no package version or changelog updates.

Assisted-By: Cursor Grok 4.5
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

@andrewkroh
andrewkroh marked this pull request as ready for review August 4, 2026 16:34
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

@vera-review-bot

Copy link
Copy Markdown

No issues across the latest commits 1bc5f46.

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:kolide Kolide Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant