Skip to content

[Chargeback] 0.4.1: Workload Breakdown type/namespace columns - #20554

Open
JohannesMahne wants to merge 4 commits into
wip-johannes-chargebackfrom
feature/chargeback-0.4.1-workload-table
Open

[Chargeback] 0.4.1: Workload Breakdown type/namespace columns#20554
JohannesMahne wants to merge 4 commits into
wip-johannes-chargebackfrom
feature/chargeback-0.4.1-workload-table

Conversation

@JohannesMahne

@JohannesMahne JohannesMahne commented Aug 5, 2026

Copy link
Copy Markdown

Summary

Test plan

  • ES|QL for updated table returns columns in order on stack 9.2.2
  • Kibana Usage dashboard shows table columns; pies gone
  • Reinstall/replace Chargeback dashboard from package

Made with Cursor

JohannesMahne and others added 4 commits August 3, 2026 17:17
@JohannesMahne @cursoragent
[Chargeback] 0.4.1 bulk: ds_type/ds_namespace panels, event.ingested,…
f9faf02 
… docs

Ship low-dependency patch on kibana ^9.2: parse data stream type/namespace
with Usage breakdown panels (no control-bar filters), ECS event.ingested on
lookup destinations, and install/reconciliation docs for #96/#66.

Co-authored-by: Cursor <cursoragent@cursor.com>
@JohannesMahne @cursoragent
[Chargeback] Fix empty Usage dashboard: sync billing transforms on @t…
e12347c 
…imestamp

billing_realized_pool and billing_cluster_cost synced on event.ingested, which
is often unmapped on On-Prem Billing indices, leaving realized_pool empty and
Usage panels blank.

Co-authored-by: Cursor <cursoragent@cursor.com>
@JohannesMahne @cursoragent
[Chargeback] Document realized_pool sync and empty Usage dashboard check
1dc11f9 
Co-authored-by: Cursor <cursoragent@cursor.com>
@JohannesMahne @cursoragent
[Chargeback] Put ds_type/ds_namespace on Workload Breakdown table
dca2f4d 
Remove the temporary namespace/type pie charts. Extend Workload Breakdown
by Data Tier with Data stream type and Namespace as leading columns.

Co-authored-by: Cursor <cursoragent@cursor.com>
@JohannesMahne
JohannesMahne requested a review from a team as a code owner August 5, 2026 13:57
This was referenced Aug 5, 2026
Open
Closed
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

💔 Build Failed

Failed CI Steps

History

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

TL;DR

The failing Buildkite step is caused by a brittle dev-script unit test that hardcodes 10-character short SHAs, while this CI run returned 11-character short SHAs. This is a test fragility/config drift issue rather than a Chargeback package logic failure.

Remediation

  • Rebase feature/chargeback-0.4.1-workload-table onto current main so it picks up the newer dev/scripts/test_get_release_commit.sh approach that avoids hardcoded repo SHAs.
  • If rebasing is not possible, update .buildkite/scripts/run_dev_scripts_tests.sh to compute expected commits dynamically (or normalize commit-length handling) before re-running bash .buildkite/scripts/run_dev_scripts_tests.sh.
Investigation details

Root Cause

The failing assertions are in .buildkite/scripts/run_dev_scripts_tests.sh and require fixed literal short SHAs:

  • .buildkite/scripts/run_dev_scripts_tests.sh:L90 expects 43bb655db0
  • .buildkite/scripts/run_dev_scripts_tests.sh:L94 expects 8b024204a8
  • .buildkite/scripts/run_dev_scripts_tests.sh:L98 expects fd04de398f

But dev/scripts/get_release_commit.sh extracts commit IDs via git log --oneline (dev/scripts/get_release_commit.sh:L64-L67), where short-hash length is environment/git-config dependent. In this Buildkite run, the same commits were emitted with one extra character (11-char short SHA), causing strict string equality checks to fail.

Evidence

  • Build: https://buildkite.com/elastic/integrations/builds/47278
  • Job/step: :bash: Dev scripts unit tests
  • Key log excerpt:
    • FAIL: finds commit for package at packages/<p>/ (unquoted version) — expected '43bb655db0', got '43bb655db05'
    • FAIL: finds commit for package at packages/<p>/ (quoted version) — expected '8b024204a8', got '8b024204a84'
    • FAIL: finds commit for version promoted from beta — expected 'fd04de398f', got 'fd04de398f1'

Verification

  • Reviewed the failing step log and mapped failures to the exact assertion lines and commit-extraction logic above.

Follow-up

  • After rebasing or patching the test script, rerun Buildkite; this should clear the current failure class unless a separate regression appears.

What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

This was referenced Aug 5, 2026
Open
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JohannesMahne