Skip to content

fix(cli): Detect TTY for interactive mode instead of hardcoding true#4219

Open
RobertWHurst wants to merge 1 commit intoelectron:mainfrom
RobertWHurst:fix/start-interactive-tty-detection
Open

fix(cli): Detect TTY for interactive mode instead of hardcoding true#4219
RobertWHurst wants to merge 1 commit intoelectron:mainfrom
RobertWHurst:fix/start-interactive-tty-detection

Conversation

@RobertWHurst
Copy link
Copy Markdown

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

A very simple change to detect if stdin belongs to a proper tty before enabling interactive mode. This makes running forge in non interactive contexts possible.

@RobertWHurst RobertWHurst requested a review from a team as a code owner April 17, 2026 03:52
Copy link
Copy Markdown
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erickzhao erickzhao changed the title Detect TTY for interactive mode instead of hardcoding true fix(cli): Detect TTY for interactive mode instead of hardcoding true Apr 17, 2026
@erickzhao
Copy link
Copy Markdown
Member

Hey @RobertWHurst, this organization requires you to sign your commits before a PR is mergeable. Do you mind rebasing your PR with signed commits so I can merge? Thanks!

@RobertWHurst
Copy link
Copy Markdown
Author

absolutely. I'll do that soon. Sorry for the delayed response - busy week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants