aeaconf2 integration#178
Open
safinsingh wants to merge 1 commit into
Open
Conversation
sourque
reviewed
Nov 1, 2023
sourque
left a comment
sourque
left a comment
Collaborator
There was a problem hiding this comment.
Looks really cool. Should be a huge QoL improvement for writing configs.
| Pass []cond | ||
| PassOverride []cond | ||
| } | ||
| var funcRegistry map[string]reflect.Type |
Collaborator
There was a problem hiding this comment.
You can init this in var with type inference eg var funcRegistry = make(map[string]reflect.Type). Having a map to a reflect type smells really bad though LOL I'll have to understand the code
| return err | ||
| } | ||
| field.SetString(datum) | ||
| } else if fieldType.Implements(reflect.TypeOf((*aeaconf2.Condition)(nil)).Elem()) { |
Collaborator
There was a problem hiding this comment.
This may look better as a function on the aeaconf struct. Maybe something like ModifyFields that takes a func(string) string as a parameter? Then we don't have to do the Implements stuff
Collaborator
Author
There was a problem hiding this comment.
Yeah I could probably just do that on the aeaconf side
Collaborator
Author
There was a problem hiding this comment.
Added on v0.1.2 (compat.ModifyConditionStrings)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue for new config format:
https://github.com/safinsingh/aeaconf2This initial commit contains some basic work for integrating
aeaconf2. It does not compile yet. Transitioning should be fairly easy based on what I've done already. Please let me know if I need to make any changes toaeaconf2to accommodate foraeacus's functionality.