Move Completed checkbox next to plan picker; share bar with Books tab - #20
Merged
Conversation
New ListToolbar component holds the Completed checkbox and, on /plan only, the PlanPicker chip — both previously separate (checkbox in Layout's header, chip in its own bar). Also rendered on the Books tab (checkbox only, no chip), so both list views get the same toolbar treatment; History doesn't, since HistoryList never reads api.showCompleted() and there'd be nothing for the checkbox to do there. The checkbox is pushed to the far right via margin-left: auto on .showCompleted, which holds its position whether or not the chip is also present, so it doesn't visually shift between the Books and Plan tabs. Layout's header grid — added in an earlier PR specifically to keep the (then title-embedded) plan picker from overlapping the checkbox — is now dead weight and reverted to a plain block layout, since neither the checkbox nor a picker lives there anymore. Also mutes the disabled chevron on a ChapterGroup row that can't expand (chapters().length === 0 — e.g. a fully-read book while Completed is hidden), so a non-interactive row also reads as non-interactive. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K2wCTwwVhhkSDxQxWo7UoH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New
ListToolbarcomponent holds the Completed checkbox and, on/planonly, thePlanPickerchip — both were previously separate (checkbox inLayout's header, chip in its own bar). Also rendered on the Books tab (checkbox only, no chip), so both list views get the same toolbar treatment./historydoesn't get one, sinceHistoryListnever readsapi.showCompleted()— there'd be nothing for the checkbox to do there.The checkbox is pushed to the far right via
margin-left: autoon.showCompleted, which holds its position whether or not the chip is also present, so it doesn't visually shift between the Books and Plan tabs.Layout's header grid — added in an earlier PR specifically to keep the (then title-embedded) plan picker from overlapping the checkbox — is now dead weight and reverted to a plain block layout, since neither the checkbox nor a picker lives in the header anymore.Also mutes the disabled chevron on a
ChapterGrouprow that can't expand (chapters().length === 0— e.g. a fully-read book while Completed is hidden), so a non-interactive row also reads as non-interactive.Test plan
npm run buildpassestsc --noEmitpassesapi.showCompleted()correctly from its new locationcolor: var(--color-muted),opacity: 0.4) versus a normal row's full-opacity black chevronGenerated by Claude Code