Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
I noticed that the logged URLs are invalid when you specify an IPv6 address as bind address. For example, this is what got logged in my case:
The URL should be formatted as
http://[::1]:4000to avoid ambiguity between IPv6 address components and the port number.This PR checks if the bind address is an IPv6 address, and then adds the square brackets as needed.
Note: I didn't go for a simpler
if ':' in self.bind_addr. This kinda works, but it would also match things likelocalhost:8080, which people might accidentally put in theaddressargument of the constructor.