Repository navigation
fix: prevent maxUnavailable 100% / maxSurge 0 rollout stalls - #1269
Merged
Merged
Conversation
This commit ensures replicant pods are annotated with scaling-down annotations _before_ acting on admission decisions. Specifically, this allows evacuations to avoid considering admitted nodes as migration targets.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-3.x #1269 +/- ##
============================================
+ Coverage 79.64% 80.17% +0.53%
============================================
Files 51 52 +1
Lines 4504 4514 +10
============================================
+ Hits 3587 3619 +32
+ Misses 773 755 -18
+ Partials 144 140 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This commit covers few more edge cases, and ties decisions to the cause: in specific situations decision depend on if it's scale down or rolling update.
keynslug
marked this pull request as ready for review
September 17, 2026 18:12
zmstone
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a subtle rollout edge case that may prevent replicant rollouts from finishing when:
maxUnavailable= 100% or a number with the same effect.maxSurgeis 0.Also, a couple more minor edge cases around replicant evacuation decisions are addressed.