Repository navigation
build: install the CMake export once, not twice - #271
Merged
Merged
Conversation
CMakeLists.txt calls install(EXPORT ${PROJECT_NAME} ...) twice. The second
call differs from the first only by not passing FILE, so it installs the same
export a second time under the default name qmqtt.cmake, alongside the
qmqttTargets.cmake the first call produces.
Nothing includes qmqtt.cmake: the generated qmqttConfig.cmake pulls in
qmqttTargets.cmake. The result is two identical exports shipped under two
names, which downstream packagers then have to notice and strip.
Drop the second call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMakeLists.txtcallsinstall(EXPORT ${PROJECT_NAME} ...)twice.The second call differs from the first only by not passing
FILE, so it installs the same export a second time under the default nameqmqtt.cmake, next to theqmqttTargets.cmakethe first call produces:Nothing includes
qmqtt.cmake— the generatedqmqttConfig.cmakepulls inqmqttTargets.cmake. So it is two identical exports shipped under two names, which is also what rpmlint flags downstream (files-duplicate).This drops the second call. Consumers doing
find_package(qmqtt)are unaffected, since that path goes throughqmqttConfig.cmakeeither way.Noticed while packaging qmqtt for openSUSE.