Skip to content

[CI] Skip building binaryen from source on macOS #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CI] Skip building binaryen from source on macOS #1704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,10 @@ def test_binaryen_from_source(self):
if WINDOWS:
# It takes over 30 mins to build binaryen using Visual Studio in CI
self.skipTest('test is too slow under windows')
if MACOS:
# Our CI uses and older version of macOS which only as 14.3.1
# TODO: Remove this if/when we update the emsdk CI.
self.skipTest('building binaryen requries xcode 15.3 because it uses std::ranges')
run_emsdk(['install', '--build=Release', 'binaryen-main-64bit'])

def test_no_32bit(self):
Expand Down