Fix `HTMLFormRenderer` to ensure a valid `datetime-local` format by mgaligniana · Pull Request #9365 · encode/django-rest-framework

mgaligniana · 2024-04-04T19:28:52Z

Description

Hi!

This PR delete everything after the first 3 digits of the miliseconds part of a DateTimeField input at HTMLFormRenderer to avoid break in browsers:

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/datetime-local#try_it

Please execute ./runtests.py TestDateTimeFieldHTMLFormRender to run the new tests

Fix #5363

mgaligniana · 2024-05-27T15:47:19Z

Hi @auvipy! Following your comment on #5363 (comment) I ask if you could do the review! Thank you!

stale · 2025-04-27T18:31:20Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

auvipy

please address the review comment

mgaligniana · 2025-04-28T03:50:36Z

Thanks @auvipy! I'll do it!

mgaligniana · 2025-06-10T13:41:57Z

Just an update here. I'm still active! I'll do as soon as possible

mgaligniana · 2025-07-26T13:21:17Z

I finally did it, sorry for the long delay!

Copilot

Pull Request Overview

This PR fixes HTML5 datetime-local input formatting by truncating milliseconds to 3 digits to ensure browser compatibility. The HTML5 datetime-local input type specification only supports up to 3 digits of milliseconds precision, but DRF was potentially outputting more digits which caused browser validation errors.

Modifies the datetime-local field value formatting in HTMLFormRenderer to limit milliseconds to 3 digits
Adds a test case to verify the correct datetime-local input formatting

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
rest_framework/renderers.py	Updates datetime-local field formatting to truncate milliseconds to 3 digits
tests/test_renderers.py	Adds test case to verify datetime-local input formatting with milliseconds

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

peterthomassen

Thanks. I have two more remarks:

Timezones currently get dropped, but I assume that's fine because this is about datetime-local which "represent[s] a local date and time, with no time-zone offset information".
The transformation assumes that the string format is iso-8601. It doesn't work if I specify, for example, appointment = serializers.DateTimeField(format='%a %d %b %Y, %I:%M%p'). Shouldn't the internal value be used as an input?

mgaligniana · 2025-08-19T19:53:26Z

Thank you Peter!

Not sure if I'm following: do you mean use the datetime value instead of the input.value (string)?

So let me know if you want to fix this in this pull request

peterthomassen · 2025-08-19T20:04:17Z

do you mean use the datetime value instead of the input.value (string)?

Yes, that's what I meant. Sorry for being unclear!

browniebroke · 2025-08-20T12:00:33Z

I tried to use this branch on a Django project with TIME_ZONE="Europe/Paris" and I'm getting a similar error as the original report, bacause the timezone is not Z but +02:00 at the end. While it feels a bit out of scope of what this fix is trying to do, this last suggestion could address it as well?

mgaligniana · 2025-08-20T13:21:47Z

Correct! I'll go for that approach and add one more test for that case Bruno! Thanks!

stale

mgaligniana · 2025-08-21T13:43:32Z

@browniebroke and @peterthomassen thank you so much for your quick reviews and guidance! 🙏

It would be nice to add a couple of test cases with some non-naive datetimes, with a timezone specified. Could try with UTC and another timezone where the offset is non-zero

Sure, I'll add a new test with timezone!

I'm not sure. Is it guaranteed that there is always a parent?

Good question. I didn't fully understand what is parent so I'll read more code to be sure and add new cases if needed!

mgaligniana · 2025-10-16T01:21:55Z

Also, the tests have quite some code duplication (I'm not sure if that is a problem).

Yes!! Of course, I can improve that!

Tests are prettier now! (I hope so)

mgaligniana · 2025-10-20T02:29:27Z

I've also renamed the format to format_ as it is a Python reserved word

mgaligniana · 2025-10-20T03:03:33Z

@peterthomassen I would need your email to add you as Co-authored-by I think (I rebased it to make it only 1 commit)

peterthomassen · 2025-10-20T07:33:52Z

I've also renamed the format to format_ as it is a Python reserved word

What makes you think that? -- I believe it is not. There are also multiple functions in DRF that define variables with that name (you can find some via git grep 'def .*format=').

@peterthomassen I would need your email to add you as Co-authored-by I think (I rebased it to make it only 1 commit)

Thanks, but that's not necessary :-) Anyway, by address is "my first name" at desec dot io.

mgaligniana · 2025-10-20T11:29:36Z

I meant this builtin function: https://docs.python.org/3/library/functions.html#format I realized when editor highlighted to me

peterthomassen

Ah, I understand what you mean. (That's not reserved, but a built-in, which is shadowed when you redeclare it.)

Anyway, looks great to me now!

mgaligniana · 2025-10-20T11:47:11Z

Ahhh correct! Thank you Peter!!!

Co-authored-by: Peter Thomassen

ionelmc

@auvipy hello, can you please revert this change and do another drf release? This PR needs more work as it doesn't handle missing or empty defaults. This PR makes rendering fail hard if no defaults are specified for the fields.

ionelmc · 2026-03-24T13:36:26Z

+            except AttributeError:
+                format_ = api_settings.DATETIME_FORMAT
+
+            if format_ is not None:


This seems to allow another type of failure if the format is None.

ionelmc · 2026-03-24T13:38:17Z

        field = field.as_form_field()

-        if style.get('input_type') == 'datetime-local' and isinstance(field.value, str):
-            field.value = field.value.rstrip('Z')


The previous code allowed blank values, the new one doesn't. This makes rendering fail if no defaults are specified.

ionelmc · 2026-03-24T13:39:15Z

+            datetime(2024, 12, 24, 0, 55, 30, 345678, tzinfo=ZoneInfo('Asia/Tokyo')),  # +09:00
+            "2024-12-23T09:55:30.345"  # Rendered in -06:00
+        )
+


Tests are missing the case where the value is empty (allowed and working in the previous drf release).

ionelmc · 2026-03-24T13:49:20Z

@auvipy hello, can you please revert this change and do another drf release? This PR needs more work as it doesn't handle missing or empty defaults. This PR makes rendering fail hard if no defaults are specified for the fields.

Ok, nevermind, this would fix it #9928

…er (encode#9365) * Fixed encode#5363 -- HTML5 datetime-local valid format HTMLFormRenderer Co-authored-by: Peter Thomassen * Add condition to make code cleanable by pyupgrade --------- Co-authored-by: Bruno Alla <alla.brunoo@gmail.com>

auvipy self-requested a review May 27, 2024 16:08

auvipy requested a review from a team June 10, 2024 07:08

peterthomassen requested changes Jun 10, 2024

View reviewed changes

Comment thread rest_framework/renderers.py Resolved

stale Bot added the stale label Apr 27, 2025

auvipy reviewed Apr 28, 2025

View reviewed changes

stale Bot removed the stale label Apr 28, 2025

deepakangadi reviewed Jul 25, 2025

View reviewed changes

Comment thread tests/test_renderers.py Resolved

mgaligniana force-pushed the issue-5363 branch from c967a6f to 29e41f1 Compare July 26, 2025 13:19

mgaligniana requested a review from auvipy July 30, 2025 14:58

auvipy requested a review from Copilot August 16, 2025 09:33

Copilot AI reviewed Aug 16, 2025

View reviewed changes

Comment thread rest_framework/renderers.py Resolved

Comment thread tests/test_renderers.py Resolved

mgaligniana requested a review from peterthomassen August 17, 2025 20:57

auvipy previously approved these changes Aug 18, 2025

View reviewed changes

peterthomassen reviewed Aug 19, 2025

View reviewed changes

auvipy self-requested a review August 20, 2025 14:07

mgaligniana commented Aug 21, 2025

View reviewed changes

Comment thread rest_framework/renderers.py Resolved

mgaligniana force-pushed the issue-5363 branch 2 times, most recently from 6d5cff3 to 0c2b20c Compare August 21, 2025 04:12

browniebroke reviewed Aug 21, 2025

View reviewed changes

Comment thread tests/test_renderers.py Resolved

peterthomassen reviewed Oct 17, 2025

View reviewed changes

Comment thread tests/test_renderers.py Resolved

peterthomassen reviewed Oct 17, 2025

View reviewed changes

Comment thread tests/test_renderers.py Resolved

peterthomassen reviewed Oct 17, 2025

View reviewed changes

Comment thread tests/test_renderers.py Resolved

mgaligniana force-pushed the issue-5363 branch 2 times, most recently from 5468bca to 89efdab Compare October 20, 2025 03:00

peterthomassen previously approved these changes Oct 20, 2025

View reviewed changes

mgaligniana requested a review from browniebroke October 23, 2025 17:49

browniebroke reviewed Oct 24, 2025

View reviewed changes

Comment thread tests/test_renderers.py Resolved

mgaligniana dismissed peterthomassen’s stale review via dba1179 October 27, 2025 21:00

mgaligniana force-pushed the issue-5363 branch from 89efdab to dba1179 Compare October 27, 2025 21:00

browniebroke reviewed Oct 27, 2025

View reviewed changes

Comment thread rest_framework/renderers.py Resolved

Fixed encode#5363 -- HTML5 datetime-local valid format HTMLFormRenderer

d275c59

Co-authored-by: Peter Thomassen

mgaligniana force-pushed the issue-5363 branch from dba1179 to d275c59 Compare October 28, 2025 15:18

browniebroke added 2 commits October 29, 2025 19:38

Add condition to make code cleanable by pyupgrade

03d842c

Merge branch 'main' into issue-5363

8de7110

browniebroke approved these changes Oct 29, 2025

View reviewed changes

browniebroke added this to the 3.17 milestone Oct 29, 2025

browniebroke added the Bug label Oct 29, 2025

auvipy approved these changes Oct 30, 2025

View reviewed changes

auvipy merged commit 01659c0 into encode:main Oct 30, 2025
7 checks passed

browniebroke changed the title ~~Fixed #5363 -- HTML5 datetime-local valid format HTMLFormRenderer~~ Fix HTMLFormRenderer to ensure a valid datetime-local format Oct 30, 2025

ionelmc reviewed Mar 24, 2026

View reviewed changes

Conversation

mgaligniana commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

mgaligniana commented May 27, 2024

Uh oh!

Uh oh!

stale Bot commented Apr 27, 2025

Uh oh!

auvipy left a comment

Choose a reason for hiding this comment

Uh oh!

mgaligniana commented Apr 28, 2025

Uh oh!

mgaligniana commented Jun 10, 2025

Uh oh!

Uh oh!

mgaligniana commented Jul 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

peterthomassen left a comment

Choose a reason for hiding this comment

Uh oh!

mgaligniana commented Aug 19, 2025

Uh oh!

peterthomassen commented Aug 19, 2025

Uh oh!

browniebroke commented Aug 20, 2025

Uh oh!

mgaligniana commented Aug 20, 2025

Uh oh!

Uh oh!

Uh oh!

mgaligniana commented Aug 21, 2025

Uh oh!

mgaligniana commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mgaligniana commented Oct 20, 2025

Uh oh!

mgaligniana commented Oct 20, 2025

Uh oh!

peterthomassen commented Oct 20, 2025

Uh oh!

mgaligniana commented Oct 20, 2025

Uh oh!

peterthomassen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mgaligniana commented Oct 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ionelmc left a comment

Choose a reason for hiding this comment

Uh oh!

ionelmc Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

ionelmc Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

ionelmc Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

ionelmc commented Mar 24, 2026

Uh oh!

Reviewers

mgaligniana commented Apr 4, 2024 •

edited

Loading

mgaligniana commented Oct 16, 2025 •

edited

Loading

peterthomassen left a comment •

edited

Loading