[joaovitoriasilva]

What does this PR do?

Adds MailMessage.from_address: str | None = None. When set, it is the message's sender (the From header, the envelope sender as its bare address, and the Message-ID domain) in place of the configured mail.from_address, which becomes the default.

• SmtpMail and MemoryMail pass it to build_mime, which validates it with the same parse_address(role="sender") as the configured sender. An invalid value is a ValueError that does not echo it, and the header-injection guarantees are unchanged.
• It is part of __hash__ and equality.
• JASIL keeps no allowlist; the relay decides which senders it accepts. The docs, the threat model ("Sender spoofing") and the integration checklist say to take it from the host's own configuration, never from user input.

Additive: a new MailMessage field with a default.

Related issue

Closes #54

Type of change

• Bug fix
• New feature (exception during freeze; link prior discussion/acknowledgment)
• Documentation
• Refactor / code quality
• Translation
• Other (describe below)

Checklist

• This PR is focused on a single concern
• An issue was opened and acknowledged before writing this code (if not a small fix)
• If this PR introduces a new feature during freeze, it was discussed and explicitly acknowledged first
• The PR is under ~300 lines changed, excluding lock files, migrations, and generated code
• Tests have been added or updated where applicable
• Documentation has been updated where applicable
• Commit messages follow Conventional Commits format

Notes for the reviewer

• Named from_address, not sender as the issue proposed. It matches MailSettings.from_address, and RFC 5322 has a Sender: header with a different meaning.
• An empty string is refused, not treated as "use the default". Only None falls back, so a host bug that produces "" fails loudly.
• Out of scope: a bounce (envelope) address separate from From, which bulk senders sometimes want. It can be added when a host needs it.
• Conflicts: this PR will conflict with feat(providers): tell a caller why a mail send failed and whether it may have been delivered #59 in SmtpMail.send and CHANGELOG.md. I'll rebase whichever merges second.

Checks run: ruff, ruff format, lint-imports, mypy, pytest (3656 passed, 139 skipped, 97.79% coverage), check_module_coverage.py, check_docs_api.py.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 37390dd6-6c65-43a3-9a52-e423184b38c4

Commits

Reviewing files that changed from the base of the PR and between d7d77a9 and 539c252.

Files selected for processing: 10

• CHANGELOG.md
• docs/configuration.md
• docs/providers-and-backends.md
• docs/security/integration-checklist.md
• docs/security/threat-model.md
• jasil/backends/mail_memory.py
• jasil/backends/mail_smtp.py
• jasil/providers.py
• jasil/settings.py
• tests/test_mail.py

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn