Support for React 17 #2429

Activity

1. layershifter commented on Aug 11, 2020

   

   layershifter

   on Aug 11, 2020

   Author

   More actions

   A CodeSandbox is ready: https://codesandbox.io/s/cranky-euclid-4qr9z
   It's enough to use mount(<div />) to repro it, see index.test.js.
2. ljharb commented on Aug 11, 2020

   

   ljharb

   on Aug 11, 2020

   Member

   More actions

   I would never expect enzyme to "just work" with a new major version of React out of the box :-) React breaks things in minors often enough as it is.

   First, I have to create an adapter for React 17, and then we'll be able to look at the test failures and go from there.

   👍React with 👍20Reacted by Oleksandr Fediashov, Kamil Dzieniszewski, Sibasish Mohanty, Tim, Song Jia, 俊宁, Antti Ahti, Vladimir Saveliev, Elnaz, Wilbert Cedeno and 10 more

   😕React with 😕3Reacted by Marouane Trabelsi, Elle Baker and Ashfaq Mahmood Rafi
3. layershifter commented on Aug 12, 2020

   

   layershifter

   on Aug 12, 2020

   Last edited by layershifter

   Author

   More actions

   @ljharb I started #2430 as I would like to run tests on React 17 ASAP 😺 Appreciate your eyes on it
4. ljharb

   self-assigned this

   on Aug 12, 2020
5. ljharb commented on Aug 12, 2020

   

   ljharb

   on Aug 12, 2020

   Member

   More actions

   Thanks, but that isn't going to speed anything up. enzyme won't be guaranteed to work on React 17 until it's fully released, not a preview.

   👍React with 👍5Reacted by Henry Q. Dineen, 俊宁, Rob Wierzbowski, Ashfaq Mahmood Rafi and Wilfried Lawson

   😕React with 😕13Reacted by Oleksandr Fediashov, Ricky, Sebastian "Sebbie" Silbermann, 俊宁, Ali Bayatpour, Shrihari Murali, Aleksey Levenstein, Andrew E McKendrick, Amir Muhammad Hakim, Danila Loginov and 3 more
6. wojtekmaj commented on Aug 18, 2020

   

   wojtekmaj

   on Aug 18, 2020

   More actions

   I think no one expects everything to work right from the start, but it would be nice to just have the adapter preview so we can find bugs early :)

   👍React with 👍8Reacted by Ricky, Sebastian "Sebbie" Silbermann, Alessio Petrin, William Zimmermann, Ryan Harrigan, Hugo Lopes, Ashfaq Mahmood Rafi and Carlos Bensant
7. ljharb commented on Aug 18, 2020

   

   ljharb

   on Aug 18, 2020

   Member

   More actions

   That is certainly my hope and plan, just not something i can commit to, since the react team hasn’t coordinated with me prior to releases in years.

   😕React with 😕10Reacted by Alexander Quine, Allan Kimmer Jensen, gsimionato-daitan, Amir Muhammad Hakim, Bluefitdev, Wilbert Cedeno, Kane Rogers-Wong, Alireza Zarei, Ashfaq Mahmood Rafi and Carlos Bensant
8. gaearon commented on Aug 19, 2020

   

   gaearon

   on Aug 19, 2020

   Last edited by gaearon

   Contributor

   More actions

   It’s fair we haven’t reached out before this particular RC since we generally view an RC as a “reachout” to the whole community. But I believe I did file #2358 (16.14 compatibility). Our plans for 16.14 changed and that release turned into 17 but I’d expect the naming change described in that issue to be the primary one you’d need to address. (Although I could totally be missing something!) Sorry for the frustration.

   👍React with 👍22Reacted by Brian Espinosa, Alexander Quine, Bill Sorensen, Xavier Ramirez, Aleksey Levenstein, gsimionato-daitan, Bluefitdev, Lata Tiwari, Nathan Victor, Said Akhmed Agitaev and 12 more
9. ljharb commented on Aug 19, 2020

   

   ljharb

   on Aug 19, 2020

   Member

   More actions

   @gaearon fair point that there's been nonzero efforts, primarily from you personally, which I appreciate. Thanks for pointing me to that issue; I'll incorporate that into the update.

   ❤️React with ❤️9Reacted by dan, Alexander Quine, Christopher Svanefalk, Kane Rogers-Wong, Jordan Wallet, Alireza Zarei, Karl-Aksel Puulmann, Ashfaq Mahmood Rafi and Carlos Bensant
10. wojtekmaj commented on Aug 24, 2020

    

    wojtekmaj

    on Aug 24, 2020

    Last edited by wojtekmaj

    More actions

    For those impatient ones (myself included), I published @wojtekmaj/enzyme-adapter-react-17 package. It's exactly like enzyme-adapter-react-16, just the necessary bits replaced.

    Use it like any other adapter, so:

    import Adapter from '@wojtekmaj/enzyme-adapter-react-17';
    
    enzyme.configure({ adapter: new Adapter() });

    I tested it on a semi large repository (2000 tests) with no failures, so it should be good enough to use, if the only thing blocking you was a broken adapter.

    I will deprecate the package once an official adapter is released. lol

    Enjoy!

    👍React with 👍295Reacted by Anton Lavrenov, Filipp Riabchun, Oleksandr Fediashov, Tommy Chen, Takanori Ishikawa, Triguna Mutuguppe Sripathi, Arun Kumar, Mat, Tomasz Jaskula, Jiri Spac and 285 more

    😄React with 😄21Reacted by Luis Felipe Martins, Maksim Yepifanau, Adam Scarlat, Lucas Simões, Daniel Shelton, Evgeny Bobkin, nhiguchi-stb, MCMXC, Кирилл Капитальцев, Artur and 11 more

    🎉React with 🎉35Reacted by Nathan Victor, Meryl, Luis Toubes, Gabriel Varela, James Kim, Jesse Florig, Tata.Paweennuch, Arsi Halttunen, Cressence Tchounga, Maksim Yepifanau and 25 more

    ❤️React with ❤️112Reacted by Sasha (Alex), Marco Arduini, Naoise Golden Santos, Anna Branco, Francesco Giordano, Maxime Quandalle, Andrzej Kłapeć, Robert Danielsson, John, Angel Martinez and 102 more

    🚀React with 🚀60Reacted by Mat, Sasha (Alex), Marco Arduini, Ileriayo Adebiyi, Joel Bourbonnais, M Giridhar, Raphael Amoedo, Riccardo Tempesta - The Rick, Florian Rappl, Ioannis Cherouvim and 50 more

    👀React with 👀12Reacted by Meryl, Gabriel Varela, James Kim, Yukako IIDA, Maksim Yepifanau, Lucas Simões, Кирилл Капитальцев, Lucas Fernandes, Matthew Hill, Barry Michael Doyle and 2 more
11. trigunam commented on Sep 23, 2020

    

    trigunam

    on Sep 23, 2020 · Hidden as off-topic

    show commentMore actions
12. ljharb commented on Sep 23, 2020

    

    ljharb

    on Sep 23, 2020 · Hidden as off-topic

    show commentMore actions
13. hengkx commented on Oct 21, 2020

    

    hengkx

    on Oct 21, 2020

    More actions

    react 17 has been released.

    🚀React with 🚀33Reacted by Wojciech Maj, Kyle Szombathy, Maarten Zuidhoorn, Brian Min, xcv58, Marco Arduini, Allan Kimmer Jensen, mehran motiee, fbontin, Gerardo Nava Pereda and 23 more
14. ljharb commented on Oct 21, 2020

    

    ljharb

    on Oct 21, 2020

    Member

    More actions

    Indeed it has, thanks. I'm still working on getting the adapter set up and passing tests.

    👍React with 👍80Reacted by Jiri Spac, Valentin, Christian Wiese, daedalic, Antti Ahti, Sanborn Hilland, Jason McPeak, John Ryan, Giovanni Fumagalli, abhishekKlenty and 70 more

    ❤️React with ❤️26Reacted by Henry Q. Dineen, Alexander Quine, Aaron Hickman, Mat, Masataka Pocke Kuwabara, Marco Arduini, Kitty Giraudel, Naoise Golden Santos, Sean, E-Liang Tan and 16 more

    🚀React with 🚀6Reacted by flynntutoring, Stefanie L., Alessio Petrin, Andrei Horodinca, nhiguchi-stb and Ashfaq Mahmood Rafi

    👀React with 👀13Reacted by Ileriayo Adebiyi, Joel Bourbonnais, Bryan Doxtdator, Bruno Domingos, Sergei Startsev, justinlnx, blagodus, Eugene, Aaron Ross, Alessio Petrin and 3 more
15. taneliang

    added a commit that references this issue on Oct 28, 2020

    Fix tests by switch to unofficial Enzyme adapter

    ...

    411e600
16. 100 remaining items

    Load more

17. ljharb commented on Jan 19, 2022

    

    ljharb

    on Jan 19, 2022 · Hidden as resolved

    show commentMore actions
18. ademidun

    added a commit that references this issue on Mar 26, 2022

    move from enzyme 16 to enzyme 17

    ...

    9233017
19. JWBrownie commented on Jul 18, 2023

    

    JWBrownie

    on Jul 18, 2023 · Hidden as spam

    Last edited by JWBrownie

    show commentMore actions
20. ljharb commented on Jul 18, 2023

    

    ljharb

    on Jul 18, 2023 · Hidden as resolved

    show commentMore actions
21. VictorQueiroz commented on Jul 18, 2023

    

    VictorQueiroz

    on Jul 18, 2023 · Hidden as abuse

    show commentMore actions
22. ljharb commented on Jul 18, 2023

    

    ljharb

    on Jul 18, 2023 · Hidden as resolved

    show commentMore actions
23. aaryn101 commented on Jul 18, 2023

    

    aaryn101

    on Jul 18, 2023 · Hidden as abuse

    show commentMore actions
24. ljharb commented on Jul 19, 2023

    

    ljharb

    on Jul 19, 2023 · Hidden as resolved

    show commentMore actions
25. sbaechler commented on Jul 19, 2023

    

    sbaechler

    on Jul 19, 2023 · Hidden as outdated

    show commentMore actions
26. hoangph271 commented on Jul 19, 2023

    

    hoangph271

    on Jul 19, 2023 · Hidden as resolved

    show commentMore actions
27. ljharb commented on Jul 19, 2023

    

    ljharb

    on Jul 19, 2023 · Hidden as resolved

    show commentMore actions
28. VictorQueiroz commented on Jul 19, 2023

    

    VictorQueiroz

    on Jul 19, 2023 · Hidden as abuse

    show commentMore actions
29. aaryn101 commented on Jul 19, 2023

    

    aaryn101

    on Jul 19, 2023 · Hidden as abuse

    show commentMore actions
30. ljharb commented on Jul 19, 2023

    

    ljharb

    on Jul 19, 2023 · Hidden as resolved

    show commentMore actions
31. enzymejs

    locked as off topic and limited conversation to collaborators on Jul 19, 2023