Repository navigation
ci: add build/lint/zizmor workflow and Dependabot - #10
Merged
Merged
Conversation
gofmt curve.go (a stray //TODO comment) and check the ignored return values in the Sign/Recover benchmarks, so the repo passes gofmt and golangci-lint's default linters.
Adds a CI workflow on ubuntu-latest (gofmt, go vet, build, test, golangci-lint) plus a zizmor workflow-security scan (offline). Actions are pinned to commit SHAs with minimal contents:read permissions. Enables Dependabot for gomod and github-actions.
Point zizmor at .github/workflows/ instead of the repo root. Scanning '.' recursively picked up the vendored bitcoin-core workflows under libsecp256k1/.github/, which are inert (GitHub only runs root workflows) and produced spurious findings.
AskAlexSharov
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic CI and dependency automation to the repo (kept separate from the libsecp256k1 0.7.1 bump in #9).
Workflow (
.github/workflows/ci.yml, ubuntu-latest)go vet,go build,go test(native cgo).Hardening: workflow-level
permissions: contents: read, all actions pinned to commit SHAs,persist-credentials: falseon checkout. The workflow passes its own zizmor scan (no findings).Lint fixes (to make the new checks green on existing code)
curve.go: gofmt a stray//TODOcomment (unformatted since fix: validate coordinate bounds in IsOnCurve and scalar mul #8).secp256_test.go: check the ignored return values in the Sign/Recover benchmarks (errcheck).Dependabot (
.github/dependabot.yml)gomodandgithub-actions. (Free on GitHub; no Advanced Security required.)Verified locally: gofmt clean,
go vetclean,golangci-lint0 issues, tests pass, zizmor no findings.