magnetostatics: guard DipolarDirectSum gpu=True without CUDA (bug-sweep #31)#5363
Draft
RudolfWeeber wants to merge 1 commit into
Draft
magnetostatics: guard DipolarDirectSum gpu=True without CUDA (bug-sweep #31)#5363RudolfWeeber wants to merge 1 commit into
RudolfWeeber wants to merge 1 commit into
Conversation
#31) DipolarDirectSum::do_construct forwarded the gpu flag straight into the core actor (m_is_gpu=true) with no feature check, unlike the analogous CoulombP3M path. On a CUDA-off build this constructed and activated silently; the first force/energy call then either hit assert(not m_is_gpu) (debug) or silently computed on CPU while is_gpu() reported True (release) -- a capability misreport. Mirror the CoulombP3M convention: at the script-interface seam, if gpu=True, add 'CUDA' to required_features and call CodeInfo::check_features inside parallel_try_catch, so the unsupported request surfaces as a clean RuntimeError ("Missing features CUDA") before the core actor is created. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DipolarDirectSum::do_construct forwarded the gpu flag straight into the
core actor (m_is_gpu=true) with no feature check, unlike the analogous
CoulombP3M path. On a CUDA-off build this constructed and activated
silently; the first force/energy call then either hit assert(not
m_is_gpu) (debug) or silently computed on CPU while is_gpu() reported
True (release) -- a capability misreport.
Mirror the CoulombP3M convention: at the script-interface seam, if
gpu=True, add 'CUDA' to required_features and call
CodeInfo::check_features inside parallel_try_catch, so the unsupported
request surfaces as a clean RuntimeError ("Missing features CUDA")
before the core actor is created.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
🤖 Generated with Claude Code